geiger-rs / cargo-geiger

Detects usage of unsafe Rust in a Rust crate and its dependencies.
https://crates.io/crates/cargo-geiger
1.41k stars 66 forks source link

WIP: Fix Krates/cargo_metadata pairing #521

Open pinkforest opened 6 months ago

pinkforest commented 6 months ago

EDIT: Needs work. There are broken abstractions / couplings between krates/geiger/cargo_metadata

The only way to fix it is to upgrade the deps but that leads to a lot of breaking changes between krates / cargo_metadata which are coupled as internal abstractions that are very time consuming to eradicate and / or fix.

The biggest is cargo_metadata::PackageId is not recognised by krates anymore and the previous versions of krates have some unhandled unwrap that is deep down the parser that handles the repr (that comes from the lockfile)

The release from crates.io works fine but transient dependency messed things up for main dev which is pity.

I'll continue untangling the abstractions that are affected by the breakage in order to upgrade to fix.