search

gemini-testing / gemini

💀💀💀[DEPRECATED] Use hermione
https://github.com/gemini-testing/hermione
MIT License
1.5k stars 149 forks source link

feat(config): add support for parallelWorkersLimit config option #970

Closed thers closed 5 years ago

thers commented 5 years ago

Allows to limit maximum amount of workers run in parallel during testing. Should help running tests on servers with a lot of cpu cores (i.e. CI agent), as worker-farm (that is used for managing workers) use os.cpus().length as a default value

j0tunn commented 5 years ago

Hi. hermione has the same option named workers: https://github.com/gemini-testing/hermione#workers It would be nice to name this option consistent with hermione.

Another question: why don't you use hermione instead of gemini? gemini will be deprecated soon.

thers commented 5 years ago

We have a lot of tests built on top of gemini and even though we'll most likely switch to hermione eventually, for a now it is adequate to add this config option to fix our current issue. I named it after "similar" parallelLimit and I doubt it should have similarities with hermione config as there're not much already. If you insist on renaming then sure, will do, just let me know about it.

j0tunn commented 5 years ago

I named it after "similar" parallelLimit

parallelLimit is about browser sessions, not about workers. So no, these options are not similar at all. And I think you should be interested in similarities with hermione config here if you plan to switch to hermione eventually.

thers commented 5 years ago

@j0tunn ping

j0tunn commented 5 years ago

gemini@7.5.0