Non meaningful error when password is incorrect

stevedomin commented 8 years ago

While attempting to send through my Sendgrid account I got stuck on this error for ages. Basically my password had some special characters and I guess I needed to do some escaping, unfortunately the error reported wasn't helpful at all.

I'm wondering if these anything we can do to show a more meaningful error to the user. I'm more than happy to contribute, but I'll need some guidance.

I had to uncomment some logging to figure out the issue (see logs below).

(This is elixir, not erlang, sorry about that)

iex(1)> :gen_smtp_client.send_blocking({"from", ["to"], "Subject: testing\r\nFrom: Andrew Thompson \r\nTo: Some Dude \r\n\r\nThis is the email body"}, [relay: "smtp.sendgrid.net", username: "username", password: "passwordwithspecialcharacter", auth: :always, tls: :always])
connected to smtp.sendgrid.net; banner was  SG ESMTP service ready at x.sendgrid.net

Extensions are [{<<"8BITMIME">>,true},
                {<<"PIPELINING">>,true},
                {<<"SIZE">>,<<"31457280">>},
                {<<"STARTTLS">>,true},
                {<<"AUTH">>,<<"PLAIN LOGIN">>},
                {<<"AUTH=PLAIN">>,<<"LOGIN">>}]
Extensions are [{<<"8BITMIME">>,true},
                {<<"PIPELINING">>,true},
                {<<"SIZE">>,<<"31457280">>},
                {<<"STARTTLS">>,true},
                {<<"AUTH">>,<<"PLAIN LOGIN">>},
                {<<"AUTH=PLAIN">>,<<"LOGIN">>}]
username prompt
password prompt
password rejected: 535 Authentication failed: Bad username / password
** (ArgumentError) argument error
               :erlang.++("username", [0 | "passwordwithspecialcharacter"])
    (gen_smtp) src/gen_smtp_client.erl:400: :gen_smtp_client.do_AUTH_each/4
    (gen_smtp) src/gen_smtp_client.erl:322: :gen_smtp_client.try_AUTH/3
    (gen_smtp) src/gen_smtp_client.erl:203: :gen_smtp_client.do_smtp_session/3
    (gen_smtp) src/gen_smtp_client.erl:142: :gen_smtp_client.try_smtp_sessions/4

Vagabond commented 8 years ago

Can you say what the special character is?

You could try something like this:

AuthString = base64:encode(io_lib:format("\0~s\0~s", [Username, Password])),

Vagabond commented 8 years ago

To replace this line:

https://github.com/Vagabond/gen_smtp/blob/master/src/gen_smtp_client.erl#L404

I mean

stevedomin commented 8 years ago

I'm getting the following error:

** (ArithmeticError) bad argument in arithmetic expression
      (stdlib) base64.erl:81: :base64.encode_l/1
      (stdlib) base64.erl:67: :base64.encode/1
    (gen_smtp) src/gen_smtp_client.erl:400: :gen_smtp_client.do_AUTH_each/4
    (gen_smtp) src/gen_smtp_client.erl:322: :gen_smtp_client.try_AUTH/3
    (gen_smtp) src/gen_smtp_client.erl:203: :gen_smtp_client.do_smtp_session/3
    (gen_smtp) src/gen_smtp_client.erl:142: :gen_smtp_client.try_smtp_sessions/4

The password was generated by 1Password so it contains /, % and )

Vagabond commented 8 years ago

Sorry, I should have tested it. Try this:

AuthString = base64:encode(list_to_binary(io_lib:format("\0~s\0~s", [Username, Password]))),

stevedomin commented 8 years ago

It's now rejecting the password twice and then I get an error tuple:

password rejected: 535 Authentication failed: Bad username / password
password rejected: 535 Authentication failed: Bad username / password
{:error, :retries_exceeded,
 {:network_failure, "smtp.sendgrid.net", {:error, :closed}}}

Vagabond commented 8 years ago

Is it possible to give me a credential on your account for testing?

stevedomin commented 8 years ago

You can create a free account at https://sendgrid.com/, comes with 12k emails free.

That's probably the simplest, otherwise happy to figure out a way to give you credentials (pgp?)

Vagabond commented 8 years ago

I will give it a try.

Vagabond commented 8 years ago

Ugh, they want to validate my 'company' and a bunch of other nonsense, which I don't really have.

stevedomin commented 8 years ago

Ah crap, do you have a pgp key (or a keybase.io account)?

Vagabond commented 8 years ago

stevedomin commented 8 years ago

account.zip

Vagabond commented 8 years ago

Ok, so I got the credentials, but I can't authenticate to their SMTP server with the credentials using their example here:

https://support.sendgrid.com/hc/en-us/articles/200182038-Testing-your-connectivity-to-Sendgrid-s-SMTP-relay-using-Telnet

I get the same Bad username / password error

Vagabond commented 8 years ago

Ok, my sendgrid account got activated (I have no idea why).

If I use the username for the account. not the email address, I can authenticate and send via sendgrid.

stevedomin commented 8 years ago

Ok, this was indeed the issue in my case (I created some testing credentials with a password without special characters, so I thought this was the issue).

Do you think we could make the error message that gen_stmp gives better? In the current form you need to manually uncomment logging statement directly in the code to figure out what's happening.

Vagabond commented 8 years ago

Yeah, that is a legitimate concern.

I tried to reproduce your original error with the 'argument' error, but I could not, we should fix that too.

keichan34 commented 8 years ago

** (ArgumentError) argument error
               :erlang.++("username", [0 | "passwordwithspecialcharacter"])

I was able to reproduce this using a binary (default for Elixir) instead of a char list for Username and Password arguments.

mworrell commented 5 years ago

@keichan34 looking at the current code I suspect your issue has been resolved.

@stevedomin Is this still a problem?

mworrell commented 5 years ago

In general: we could add a flag to enable the logging of all client/server communication for a specific request.

gen-smtp / gen_smtp

Non meaningful error when password is incorrect #96