Closed chyyran closed 2 years ago
Addressed the nits and rebased on master. See follow up comment on reasoning for CrcDigestRead/Write
.
In the meantime I've merged #82 which addresses the import formatting question.
Could you rebase on top of it to resolve the merge conflict?
Rebased on master in 698620b
Pull Request Overview
This pull request adds/changes/fixes...
byteorder
to1.4.3
log
to0.4.17
env_logger
to0.9.0
crc
to3.0.0
crc
from^1.0.0
->3.0.0
represents a very large API change. In particular, algorithms are now const-initialized andDigest
no longer implementsHash
, soWrite/Read
forDigestWrite/Read
(formerlyHasherWrite/Read
) has to be implemented per type. This results in most of the code changes in this PR.crc
and the XZ specification. See CRC-64/XZ and and CRC-32/ISO-HDLC in the catalogue of parameterised CRC algorithms.Testing Strategy
This pull request was tested by ...