geneontology / noctua-form

2 stars 0 forks source link

bug in attaching evidence for extensions in BP only form #225

Closed krchristie closed 6 months ago

krchristie commented 1 year ago

The BP form does not seem to attach evidence properly to at least some extensions. Here is the example I found:

I selected the "occurs in Anatomy" option to add a cell type extension:

20230621-CCform-evForExtension-p1

I filled in the new row for the extension and clicked "Save": 20230621-CCform-evForExtension-p2

Since the form doesn't show everything, you don't see that the extension is missing the evidence.: 20230621-CCform-evForExtension-p3

However, in you go to the graph, you see that the evidence is missing for the extension.: 20230621-CCform-evForExtension-p4

The Annotation Preview confirms that the annotation extension is missing.: 20230621-CCform-evForExtension-p5

vanaukenk commented 1 year ago

At the Noctua workbenches call (2023-06-22), we reproduced the behavior (i.e. missing evidence on occurs_in BP extension in the BP only form).

We also tested the equivalent extension in the Activity Unit form and, there, the evidence IS properly attached.

We also tested an extension in the CC only form and the evidence was also attached properly there.

@tmushayahama would like to systematically check each extension to see if evidence is correctly saved.

vanaukenk commented 1 year ago

See also: https://github.com/geneontology/noctua-form/issues/224#issuecomment-1599262489

At the Noctua workbenches call (2023-06-22), we reproduced the behavior (i.e. missing evidence on occurs_in BP extension in the BP only form).

We also tested the equivalent extension in the Activity Unit form and, there, the evidence IS properly attached.

We also tested an extension in the CC only form and the evidence was also attached properly there.

@tmushayahama would like to systematically check each extension to see if evidence is correctly saved.

vanaukenk commented 9 months ago

2023-09-14 workbenches call:

We tested on noctua-dev and this all seems to be working properly now.

@krchristie - please also confirm that this is fixed for you on noctua-dev so we can put this out onto production.