genepi / nf-gwas

A nextflow pipeline to perform state-of-the-art genome-wide association studies.
https://genepi.github.io/nf-gwas
MIT License
63 stars 21 forks source link

Request to move the tabix-merge.jar file into docker containers #75

Closed robsyme closed 1 year ago

robsyme commented 1 year ago

The ./bin folder is designed to hold small, self-contained executable scripts used by the Nextflow processes, ideally below 1MB. The nf-gwas workflow contains a 22MB jar file, which does not seem to be called directly in the pipeline.

Is this jar file still necessary for the workflow? If not, I would recommend that it be removed. If the jar file is required by one of the executables contained in the docker image, it would make sense that tabix-merge.jar is also included in the docker image.

robsyme commented 1 year ago

Closed with https://github.com/genepi/nf-gwas/pull/76