dehesselle
commented
4 years ago I'm being pedantic with my review. I think we need at least one more iteration since I have collected quite a few remarks. I haven't cross-referenced everything between the English and the German version yet, that is something left to be done in the next iteration. So my focus is mainly the English version. (You'll probably have to fix them both at the same time.)
- Maybe turn "#WirVsVirus" into a link to the hashtag on Twitter? e.g. https://twitter.com/hashtag/wirvsvirus?lang=de
- typo: "With the solution we provide, all devices in the environment are logged by your own device."
- lose "service": "From a central server ~service~, device IDs..."
- I don't like the "(!!!)". Text is already bold, please lose the exclamation marks.
- missing asterisks: you wanted to make something bold in "no display of device IDs" but the closing asterisks are missing
- Replace "We are happy about forks..." with something like "We gladly accept your contributions / pull requests."
- Authors section: maybe sort by name since there is no implied ranking?
- Authors section: is "baking" really a common term used in software development? (I Googled "software baking" and don't get relevant results.)
- After having read it multiple times, I think the "patting ourselves on the back because we are so graciously offering this under MIT license" really needs to go. You can keep everything but the first sentence. To be clear: Begin with "We want to help fight this..." and lose the sentence before.
- Lose the "A support can be done..." sentence. We've already explained above that we gladly accept contributions.
rfuehrer
this PR implements issues
Fixes #4 Fixes #5
(with credit to @dehesselle )