search

generateme / cljplot

JVM Clojure charting library
Eclipse Public License 2.0
152 stars 7 forks source link

Minor patch to density data prep #15

Closed joinr closed 5 years ago

joinr commented 5 years ago

Working through dissecting the examples, starting with the first example in cljplot/sketches/examples.clj. The plot wouldn't render.

I went ahead and deconstructed everything, found out that the side plots were causing the problem; fastmath.stats was complaining about improper arities for an anonymous function somewhere....

I eventually tracked it down to the calls from cljplot.impl.line/prepare-data :density implementation, where the calls to stats/kernel-density wanted an extra arg or otherwise (perhaps the arity has changed recently) were no longer working with the default (smile). After plugging the the :default as the dispatch value explicitly, rendering works again.

genmeblog commented 5 years ago

Ah, yes, I changed fastmath kernel density code. Also changed histogram code (histograms don't work now) in fastmath. I'll create zulip chat dedicated to cljplot to share with you breaking changes and current state of work.

genmeblog commented 5 years ago

I fixed it after bigger refactoring. So this is in the code already. Closing.