generateme / fastmath

Fast primitive based math library
MIT License
225 stars 11 forks source link

any plans for updating to smile 3.0.x ? #26

Closed behrica closed 8 months ago

behrica commented 10 months ago

I was looking into it for scicloj.ml.smile. But as it depends on fastmath, I think it would be better to upgrade fastmath before.

genmeblog commented 10 months ago

Yes, there are such plans. I'll try to figure out how to make it properly with minimal effort. The main point of changes is around clustering API (no more double-double arrays input for some functions).

behrica commented 10 months ago

yes, I saw other big changes, but not affecting fastmath I think: https://github.com/scicloj/scicloj.ml.smile/issues/12

But I use indeed the clustering from fastmath: https://github.com/scicloj/scicloj.ml.smile/blob/main/src/scicloj/ml/smile/clustering.clj

genmeblog commented 9 months ago

Indeed... I was fooled by changes in classification. I'll take a look soon and upgrade it.

genmeblog commented 9 months ago

Looks like it went smoothly. Some minor API changes in my case:

Roughly tested and all other things worked (clustering), so expect a snapshot soon.

genmeblog commented 9 months ago

BTW, all the SMILE 3.0.2 deps are:

                 [com.github.haifengl/smile-base "3.0.2"]
                 [com.github.haifengl/smile-core "3.0.2"]
                 [com.github.haifengl/smile-mkl "3.0.2"]

                 [org.bytedeco/arpack-ng "3.9.0-1.5.9"]
                 [org.bytedeco/arpack-ng-platform "3.9.0-1.5.9"]
                 [org.bytedeco/openblas "0.3.23-1.5.9"]
                 [org.bytedeco/openblas-platform "0.3.23-1.5.9"]
                 [org.bytedeco/javacpp "1.5.9"]
genmeblog commented 9 months ago

@behrica I deployed 2.3.0-SNAPSHOT. If you can test it it would be great. From my perspective clustering works.

genmeblog commented 8 months ago

Released 2.3.0 with Smile 3.0.2