search

geni-lab / ros_pololu_servo

ros catkin package for polulu servo controller board. Based on polstro
Other
8 stars 19 forks source link

missing ros_pololu_servo.msg #8

Closed linas closed 9 years ago

linas commented 9 years ago

I am trying to run the hanson robotics basic_head_api but it crashes: aparantly, it uses the ros_pololu_servo.msg which was removed by Jamie Diprose somewhere along the way. Other than stating the obvious: making backward-incompatible changes is evil, esp when you don't notify your dependent projects ... what can be done now? What is the correct work-around for this?

Part of the problem is that Hanson Robotics failed to track the changes in this repo, but removing a previously supported message without warning is also .. a bad thing.

I opened a matching bug report on the other side: See https://github.com/hansonrobotics/basic_head_api/issues/3

jdddog commented 9 years ago

Hanson Robotics was using their own fork. This is a new version (I guess there's a better way to notify that?).

I changed the message definitions to match the ROS naming conventions. The message definitions are in the msg folder.

jdddog commented 9 years ago

Btw, everybody should read ROS patterns and best practices.

jdddog commented 9 years ago

Here are examples of:

  1. how to program it
  2. how to launch it
  3. how to write a config file
jdddog commented 9 years ago

Did you sort everything out / can I close this?

linas commented 9 years ago

Above, you state:

Here are examples of:

    how to program it

    how to launch it

    how to write a config file

This info belongs in the README file, and not buried in a closed bug report. J ust made a pull request #10 for this

linas commented 9 years ago

Oh closing. basic_head_api which prompted this, is now obsolete.