geniusyield / smart-order-router

Open-source Smart Order Router framework to connect liquidity from the Genius Yield DEX
https://www.geniusyield.co
Apache License 2.0
58 stars 11 forks source link

Docker | Config: preprod network ID #45

Open 4TT1L4 opened 1 year ago

4TT1L4 commented 1 year ago

Problem:

Solution:

Blocked by:

Related code lines:

https://github.com/geniusyield/smart-order-router/blob/75aeeb733ea2c747595e2b231460601d80ed2866/docker-compose.yml#L11

https://github.com/geniusyield/smart-order-router/blob/75aeeb733ea2c747595e2b231460601d80ed2866/docker-compose.yml#L40

4TT1L4 commented 1 year ago

Some changes must be done in the Atlas code, so it would accept the preprod string as a valid networkId.

After this change was incorporated into Atlas and it is released in the next official release, then we can update our docker-compose to pass the same string to both modules.

This is going to help us to keep the configuration more flexible and simple, so we could just pass the same string to both components, both to the cardano node and the atlas provider used by the SOR. At the moment this is not really critical, since the GY DEX is only on PREPROD testnet and not yet on MAINNET, but as soon as we need to be able to simply change between different networks, this little change is going to help us to keep the config simple.

4TT1L4 commented 11 months ago

The related Atlas issue is closed. Now the preprod network ID is accepted by the most reccent Atlas version, so the preprod and mainnet network IDs could be used to configure both the Atlas backend provider and the Cardano Node, so the configuration switch between the different networks can be easily implemented.

Imprtant: We need to make sure to update the used Atlas revision to a version where the preprod network ID string is already supported.

Please see the following PR for the relevant Atlas changes:

Merged to the main branch of the Atlas repository on 2023-11-28.