search

genkgo / ember-localforage-adapter

Offline usage for Ember Data, based on localstorage adapter, but now uses Mozilla's localforage as data source
Other
133 stars 26 forks source link

Compatibility with Ember Data 1.13+ #29

Closed igorrKurr closed 9 years ago

igorrKurr commented 9 years ago

Hi!

I want to propose you to take a look at some work that I did while working on my lib that used localforage adapter. Hope this can be helpful.

frederikbosch commented 9 years ago

@igorrKurr Could you clarify which changes are done; and why? I would really happy to merge it. But before pressing the button, or check it out myself, I would like to have some details on the PR.

frederikbosch commented 9 years ago

@igorrKurr I just now understand that these commits are for the new Ember Data. Any help is really welcome on this subject. The focus should be, however, to fix the tests. My general feeling is that you focused on the browser.

frederikbosch commented 9 years ago

When I was working on this last week, I discovered that the tests never reached the calls inside the promise in the find method. I have no idea why.

frederikbosch commented 9 years ago

And that is also why Travis is complaining that it did not receive any output. No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. So the promise never gets executed.

frederikbosch commented 9 years ago

The test issues actually started at Ember Data 1.0 beta 19

frederikbosch commented 9 years ago

@igorrKurr Thanks for your effort, but #35 just fixed the Ember Data support.