search

genkgo / ember-localforage-adapter

Offline usage for Ember Data, based on localstorage adapter, but now uses Mozilla's localforage as data source
Other
133 stars 26 forks source link

_shouldSerializeHasMany was prompted to public API. #71

Closed d-schloss-mvg closed 5 years ago

d-schloss-mvg commented 7 years ago

This is fixed the deprecation warning beginning with Ember-data 2.12.

See #70

Should there be a version dependent option?

d-schloss-mvg commented 7 years ago

I invested some time and fixed the backwards compatibility.

To run the tests on CI I had to upgrade nodejs to v4. (See here updated link and here ) Other option: Pin ember-cli-htmlbars-inline-precompile version to some version with nodejs 0.12 compatibility.

The failing tasks also fail on master branch: See here which is essentially the master branch + node v4). A seperate pull request would be better suited for this I guess?

d-schloss-mvg commented 7 years ago

I fixed the failing tests. I hope this is how it was intended in the first place: here

d-schloss-mvg commented 7 years ago

FYI: uuid integration seems broken if you use it as an addon in a ember-cli project.