search

genkgo / ember-localforage-adapter

Offline usage for Ember Data, based on localstorage adapter, but now uses Mozilla's localforage as data source
Other
133 stars 26 forks source link

Remove bower_component "localforage" as dependency #75

Closed driesdl closed 5 years ago

driesdl commented 6 years ago

When performing ember install ember-localforage-adapter it installs a package in the 'bower_components' called 'localforage'. Newer Ember versions are stepping away from Bower since it's discontinued.

I removed some lines where Bower is needed. The first part when performing ember try:testall succeeds in:

Built project successfully. Stored in "D:\_GIT\ember-localforage-adapter\tmp\class-tests_dist-7Pqm11YP.tmp".

But fails in the tests:

`not ok 16 PhantomJS 2.1 - Cache integration: cache should be unbound data

    actual: >
        null
    message: >
        beforeEach failed on cache should be unbound data: undefined is not an object (evaluating 'window.localforage.setItem')
    Log: |
...

`

Feedback would be greatly appreciated.

(note: this is my first pull request, so it's all pretty new for me)

frederikbosch commented 6 years ago

@Driezzz I will try to look into it. As I do not have any active projects that use this library any more, the time I can spent to this limited. I will do the best I can.

frederikbosch commented 6 years ago

When tests succeed, I will merge this in.

frederikbosch commented 6 years ago

I think that nodejs should be upgraded in order for the tests to succeed.

frederikbosch commented 6 years ago

You might want to update the nodejs version of travis.

driesdl commented 6 years ago

It fails at the tests as mentioned in the initial comment https://github.com/genkgo/ember-localforage-adapter/pull/75#issue-169152147

frederikbosch commented 5 years ago

Thanks for the suggestion, fixed in master.

driesdl commented 5 years ago

Thank you! I'll try it out asap.

edit: it works