search

genkgo / mail

Library to send e-mails over different transports and protocols (like SMTP and IMAP) using immutable messages and streams. Also includes SMTP server.
https://mail.readthedocs.io/
Other
402 stars 21 forks source link

Tests for formats and attachments #13

Closed Lewiscowles1986 closed 7 years ago

Lewiscowles1986 commented 7 years ago

One thing most other mail libraries are really poor at is integrating attachments that are not text/plain, text/html or one of the image/* mime-types like for example ical / vcard.

It'd be really nice to see tests for that. Is it something you feel is outside of library need / support?

frederikbosch commented 7 years ago

See https://github.com/genkgo/mail/blob/master/test/Unit/Mime/FileAttachmentTest.php and combine it with the example in the readme. I havent tested vCards, but should be supported out-of-the-box.

frederikbosch commented 7 years ago

Please let me know if you find something that it is not working, closing for now.

frederikbosch commented 7 years ago

You might also want to have a look at https://github.com/genkgo/mail/blob/master/src/Mime/ResourceAttachment.php fir non-file attachments.