search

genkgo / mail

Library to send e-mails over different transports and protocols (like SMTP and IMAP) using immutable messages and streams. Also includes SMTP server.
https://mail.readthedocs.io/
Other
402 stars 21 forks source link

Consider renaming factories #14

Closed frederikbosch closed 7 years ago

frederikbosch commented 7 years ago

When developing this library, I really had a hard time picking the right names for the right jobs.

Especially the name FormattedMessageFactory is controversial. It is a factory in a sense that is producing messages: like it drops messages from the assembly line. Therefore I chose the name.

However, I also read people rather see it as a builder. That also makes sense. Maybe it makes more sense. Since the library is already in stable state, however, I will only consider changing the name in a new major release.

frederikbosch commented 7 years ago

Since this will be breaking, I will not go forward with it.