Implement null connection

[GwendolenLynch]

• Add Genkgo\Mail\Protocol\NullConnection class
• Be more informative when throwing exception on unsupported scheme

Use:

ClientFactory::fromString('null://localhost/')->newClient()

Use cases:

• Testing
• Default set up parameters
• Maintenance mode

Please feel very free to throw rejection, requests for changes, or merge my way. :wink:

[frederikbosch]

@GawainLynch Thanks! Will look at this next week. Although I have one remark already, the NullConnection would belong in the Smtp namespace since it is dedicated to SMTP only.

[GwendolenLynch]

NullConnection would belong in the Smtp namespace since it is dedicated to SMTP only.

I'm going to blame that on "Friday night" … I'll dig back into it in the morning. :+1:

[frederikbosch]

And tests for the class are missing.

[GwendolenLynch]

Moved NS & added tests.

Just to note, I had left out tests on the original PR as I had (originally) copied PlainTcpConnection and that was marked with @codeCoverageIgnore … plus this is itself a test class :wink:

[frederikbosch]

Thanks. I’d love to have tests though. There is defined behaviour, which is pretty well testable. This is not the case for the PlainTcpConnection, because you will have to open a tcp connection in another thread (other php process). Therefore I marked it as ignored for code coverage.

[GwendolenLynch]

Not a problem in the world for me. I'm just in the process of "getting to know how you work" … every project does things (slightly or more) different.

[frederikbosch]

Oh, I understand completely, and I am very happy with the fact you are contributing! In terms of how I work regarding to code: as strict as possible ;)

[GwendolenLynch]

Actually, on that … could you ping me via email (address on my GH profile), I have a couple of things to quickly run by you.

[frederikbosch]

Much obliged!

[GwendolenLynch]

A pleasure :smiley_cat: