genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
712 stars 197 forks source link

Possible to filter weapons by type in `/weapons` instead of just `/weapons/all`? #293

Open ChrisMGeo opened 3 months ago

ChrisMGeo commented 3 months ago

Currently appending ?type=Bow, etc. to /weapons/all works but not with just /weapons. Any way to make this work or is it a bad idea?

man90es commented 3 months ago

This should be possible, but it would be a very niche functionality. The only use case I can think of is if you want to get images of all bows but don't care about any other data. In a real application you'd still want to get at least names of those bows for tooltips.