gentzkow / template_archive

19 stars 36 forks source link

PR for #82: Fix issue with R dependency #83

Closed jc-cisneros closed 1 year ago

jc-cisneros commented 1 year ago

Closes #82.

In this issue we addressed an issue with a base R dependency. Concretely, both the ggplot2 and tidyverse living on conda-forge at the time of the error were up to date with CRAN, while R had not been updated to a version compatible with those packages. That generated the error shown on this comment.

The error was fixed by updating conda (which now uses an updated version of R). Given that no changes in the code were required, the changes that will be merged back to master are limited to the following:

@snairdesai the logs in the diff at the moment of this post reflect an environment that includes the R packages. I rebuilt the environment and re-run template without these packages on 3137b8a. You can then check that the logs are correct and updated and we can proceed with the merge.

I agree with the minor changes to README.md, which essentially reflect the solution described above. Nevertheless, there are instances in which that solution would not work until an update is completed on conda-forge's end. We should open a follow-up issue to discuss how to deal with scenarios like this within the current conda structure or to consider alternatives.

cc. @gentzkow