search

geoadmin / mf-geoadmin3

Legacy source code of map.geo.admin.ch
https://map.geo.admin.ch
Other
227 stars 72 forks source link

[MVT] F-001 : provide LBM style variation #4584

Open davidoesch opened 5 years ago

davidoesch commented 5 years ago

Since we dont have multiple datasets to show for MVT test viewer and we can't generate easily our variations on our own, we need an additional style so user can switch between styles to see the vector manipulation modus

Goal: besides the official LBM we would like to have an additional USER generated style in pulldown, which we link as third party style for https://github.com/geoadmin/mf-geoadmin3/issues/4581

a nice style was mantioned here https://github.com/geoadmin/config-tileservergl/pull/12

-> Can you @danduk82 organize this style for loic?

if not possible we just change the pallette of the current style using the same layers

loicgasser commented 5 years ago

A dark theme could also be nice. For fire fighters and the police.

davidoesch commented 5 years ago

I asked Sebastian for it

davidoesch commented 5 years ago

LSD Style as alternative for switch style (https://raw.githubusercontent.com/openmaptiles/fiord-color-gl-style/master/style.json)

https://mf-chsdi3.int.bgdi.ch/mvt/shorten/7eaa1556fb

pls up downvote @loicgasser @gjn @oterral

styles-ch.swisstopo.basiskarte-lsd.vt_v004.zip

davidoesch commented 5 years ago

GREY Style as alternative for switch style (https://raw.githubusercontent.com/openmaptiles/fiord-color-gl-style/master/style.json)

https://mf-chsdi3.int.bgdi.ch/mvt/shorten/7eaa141479

pls up downvote @loicgasser @gjn @oterral

styles-ch.swisstopo.leichte-basiskarte-grey.vt_v004.zip

davidoesch commented 5 years ago

basis Style as alternative for switch style (https://raw.githubusercontent.com/openmaptiles/fiord-color-gl-style/master/style.json)

https://mf-chsdi3.int.bgdi.ch/mvt/shorten/7eaa1277e3

pls up downvote @loicgasser @gjn @oterral

styles-ch.swisstopo.basiskarte.vt_v004.zip

davidoesch commented 5 years ago

to be honest I like them all! why not just toggel through? or have 3 toggles in the feedback panel: GREY, COLOR, BASE

gjn commented 5 years ago

I like them as well. And remember, the goal is not only to sell maps/styles, but it's to sell the possibilitie to create your own map. And showing people possibilities makes them hungry.

deniers commented 5 years ago

The layer structure of all of these styles (lightbase, base, grey, lsd) is the same and it will remain like this (at least until we go public with the Testviewer). We will still be tuning the styles (set different colors, line widths, or whatever) but we will not change the layer structure. So it is stable and the Testviewer can be adapted to these styles.

oterral commented 5 years ago

Definitiv basis is the best :) you can compare the rendering with Color map bg. The others are also good example.

deniers commented 5 years ago

lightbase (not yet on Testviewer) is our prime style we want to show (product management). it is light in color and (in the future) gives the user a possibility to add his own data with intense color, without making the map too heavy.

loicgasser commented 5 years ago

Great job. Basis for sure. And + 1 to add them all.

davidoesch commented 5 years ago

ok votes are done proposal for loic just split the "switch layer" button to 3 buttons / radio buttons. lets name the style "A" "B" "C" not base lsd or grey

oterral commented 5 years ago

@davidoesch translations added in excelsheeet:

vector_feedback_style_default vector_feedback_style_color vector_feedback_style_grey vector_feedback_style_lsd

deniers commented 5 years ago

@davidoesch can you publish lightbase? lightbase (not base) is the style i have been working on and it is the one we want to show. the others are just quick derivations of it. from PM point of view base is actually the least important style and we might not want to publish it at all (it looks like our normal "Landeskarte" but just a lot worse). use lightbase as default. then i suggest we add grey and may be LSD? I'm open to other suggestions

deniers commented 5 years ago

the style of lightbase with all tiles aggregated in one tileset: http://tileserver.int.bgdi.ch/styles/ch.swisstopo.leichte-basiskarte_aggregated_osm.vt_v004/?vector#12.89/47.56015/7.60972

davidoesch commented 5 years ago

we put buttons on one line

davidoesch commented 5 years ago

translations done: set button on one line, thanks @loicgasser

loicgasser commented 5 years ago

Ok will do

davidoesch commented 5 years ago

thanks done

davidoesch commented 5 years ago

Hi @loic the gls-sytles still point to my private repo: can you use this urls instead

-https://cms.geo.admin.ch/www.geo.admin.ch/cms_api/gl-styles/styles-ch.swisstopo.basiskarte.vt_v004.json

thanks

gjn commented 5 years ago

We have other styles on public.geo.

Too many hosts, we have things everywhere.

Also, caching headers ok?

On Friday, December 14, 2018, David Oesch wrote:

Hi @loic the gls-sytles still point to my private repo: can you use this urls instead

-https://cms.geo.admin.ch/www.geo.admin.ch/cms_api/gl-styles/styles-ch.swisstopo.basiskarte.vt_v004.json

thanks

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/geoadmin/mf-geoadmin3/issues/4584#issuecomment-44737512

davidoesch commented 5 years ago

You can put them on public.Geo ... No issue. It's importer that those styles are not pay of the official product...

davidoesch commented 5 years ago

wait until we have v006

deniers commented 5 years ago

in v006 all data will come from one mbtile:vektorkarte.vt (except the seperate osm data) and we will provide 3 styles: lightbase, grey and lsd (or just some really colorfull crazy stuff... not sure about it yet)

davidoesch commented 5 years ago

hi @swissgis3084 we have https://vectortiles.geo.admin.ch/gl-styles/ch.swisstopo.leichte-basiskarte-grey.vt/v006/?vector#7/47/8.25 https://vectortiles.geo.admin.ch/gl-styles/ch.swisstopo.leichte-basiskarte-vintage.vt/v006/?vector#7/47/8.25

but the colourful one we still use the same we have for v004?

davidoesch commented 5 years ago

And here we go with the third variation

therefore we have now

A https://vectortiles.geo.admin.ch/gl-styles/ch.swisstopo.leichte-basiskarte-grey.vt/v006/?vector#7/47/8.25 B https://vectortiles.geo.admin.ch/gl-styles/ch.swisstopo.leichte-basiskarte-vintage.vt/v006/?vector#7/47/8.25 C http://tileserver.int.bgdi.ch/gl-styles/ch.swisstopo.leichte-basiskarte-lsd.vt/v006/?vector#7/47/8.5

Store the style under cms.geo.admin.ch

davidoesch commented 5 years ago

Hi @boecklic

the stalye varation as above can NOT be seved via the official vectortiles.geo.admin.ch URL they need to have the warning

as mentioned above in the ticket-- you guys should not move it from my private repo to the official service but to CMS or a github repo

as a courtesy: I moved it already for you to cms.geo.admin.ch

A) https://cms.geo.admin.ch/www.geo.admin.ch/cms_api/gl-styles/ch.swisstopo.leichte-basiskarte-grey.vt_v006.json B) https://cms.geo.admin.ch/www.geo.admin.ch/cms_api/gl-styles/ch.swisstopo.leichte-basiskarte-vintage.vt_v006.json C) https://cms.geo.admin.ch/www.geo.admin.ch/cms_api/gl-styles/ch.swisstopo.leichte-basiskarte-lsd.vt_v006.json

without this fiy we can't go live

davidoesch commented 5 years ago

https://github.com/geoadmin/mf-geoadmin3/issues/4584#issuecomment-461021114 is not fixed is not attributed in [MVT] fixing background colour edition (GLStyle) #4820 image

danduk82 commented 5 years ago

@pakb please check this too while solving the issue with the style edition...

pakb commented 5 years ago

I don't understand what I'm supposed to do, styles are stored in cms.geo.admin.ch, changing background works too. Please clarify

danduk82 commented 5 years ago

@davidoesch I think this is solved, can you confirm?

davidoesch commented 5 years ago

nope it is NOT solved style A B C are considered third party datasets

according to the spec image

this should also apply for style A B and C (but not for defautl since this is an official one), be sure that you also add the footer info where A B C is stored (https://github.com/geoadmin/mf-geoadmin3/issues/4662)

boecklic commented 5 years ago

Current behaviour of test.map.geo.admin.ch: red man icon only shown if any of [default,A,B,C] is modified, but not when just using [A,B,C]. Is this correct? Or should the icon be show for edited [default,A,B,C] and non-edited [A,B,C]? Showstopper? Or can we do this in the next days?

davidoesch commented 5 years ago

-> RED activated icon be show for edited [default,A,B,C] and non-edited [A,B,C]

boecklic commented 5 years ago

and for

Showstopper? Or can we do this in the next days?

pakb commented 5 years ago

When custom style, this UI elements are missing :

Custom styles are :