search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Equivalent to NoResult Exception when updating from older versions #1182

Open VikitorGalevez opened 1 year ago

VikitorGalevez commented 1 year ago

Hi, im updating my project and i came across this problem. I have some uses for Geocoder\Exception\NoResult, but those no longer exist. Are there any equivalents? Or should i use the generic exception for this cases?

jbelien commented 1 year ago

Hello @VikitorGalevez,

I must admit I don't remember that NoResult exception ; it was probably from a version before I joined the project.

But I think you could migrate that exception catch to the isEmpty() function in AddressCollection class (see AddressCollection.php).

VikitorGalevez commented 1 year ago

The thing is we have different exceptions thrown if some conditions are met, for example in this case: if(empty($content)) { throw new NoResult(sprintf('Could not execute query "%s".', $query)); }

I was just thinking of using the normal exception. How would you use the addressCollection in this case?