search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

Return confidence from OpenCage API #1233

Open Brammm opened 3 months ago

Brammm commented 3 months ago

We have a business case where we would need the accuracy/confidence from the providers we are using. This PR adds this for OpenCage.

freyfogle commented 3 months ago

HI @Brammm Ed from OpenCage here. Thanks for this change, I am all for it. But one thing for your project, because unfortunately many people get confused by our confidence value - I just want to make sure you understand it is not a measure of "correctness". It is "just" a measure of how large the result is. Please see the details in the API docs.

Brammm commented 3 months ago

Hey @freyfogle, thanks for that heads up, I really appreciate it. We're converting the OpenCage confidence to an generalized "accuracy" in our app, but for our use case, Confidence as defined does work (e.g. with Google Maps, we're using the location type).

Brammm commented 1 month ago

@jbelien Is there anything we can do to help to get this merged? For now, we're relying on a fork.

Nyholm commented 1 week ago

This looks good. Can you please rebase so the CI is running?