search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

chore: add testruns for PHP 8.4 #1235

Closed Chris53897 closed 2 weeks ago

ruudk commented 4 weeks ago

Thanks for doing this.

@jbelien What's needed to get this merged? Anything I can do to help?

ruudk commented 2 weeks ago

@Nyholm Would you be able to help out with this?

Chris53897 commented 2 weeks ago

There is one failing test for PHP 8.4 low. https://github.com/geocoder-php/Geocoder/actions/runs/11325637108/job/31492962515?pr=1235

I guess we need to bump the minimum version of http-client? v7.0.10 ?

ruudk commented 2 weeks ago

Since symfony/http-client is a dev dependency, I think this is fine to do.

We can change it to:

-"symfony/http-client": "^5.4 || ^6.4 || ^7.0",
+"symfony/http-client": "^5.4 || ^6.4 || ^7.0.10",
ruudk commented 2 weeks ago

@Chris53897 could you make the change?

Chris53897 commented 2 weeks ago

I bumped the min version to ^5.4.45 to solve it.

ruudk commented 2 weeks ago

@Chris53897 Looks good, only a few PHP CS Fixer issues left and we can ship it! 🎉

Chris53897 commented 2 weeks ago

I have created a seperate PR for this.Am 14.11.2024 um 10:04 schrieb Ruud Kamphuis @.***>: @Chris53897 Looks good, only a few PHP CS Fixer issues left and we can ship it! 🎉

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

ruudk commented 2 weeks ago

Why, would have been easier for everyone if it was done in this one, so we could have just merged it and be done with it. Now you have to rebase this PR later again.