search

geoffdavis / esphome-mitsubishiheatpump

ESPHome Climate Component for Mitsubishi Heatpumps using direct serial connection
BSD 2-Clause "Simplified" License
498 stars 143 forks source link

Fix crash when changing fan modes #122

Closed wrouesnel closed 2 days ago

wrouesnel commented 7 months ago

Based on #120 by @markalston

This is the actual fix that's needed. I've tested and confirmed this works for me, and without it that fan mode control does not work (you get a long pause and an error).

markalston commented 7 months ago

Yes this is the line that crashes the esp. the other change is simply a formatting change so that the switch line matches the format in the rest of the code.

On November 12, 2023 6:03:55 AM MST, Will Rouesnel @.***> wrote:

Based on #120 by @markalston

This is the actual fix that's needed. I've tested and confirmed this works for me, and without it that fan mode control does not work (you get a long pause and an error). You can view, comment on, or merge this pull request online at:

https://github.com/geoffdavis/esphome-mitsubishiheatpump/pull/122

-- Commit Summary --

  • Fix crash when changing fan modes

-- File Changes --

M components/mitsubishi_heatpump/espmhp.cpp (2)

-- Patch Links --

https://github.com/geoffdavis/esphome-mitsubishiheatpump/pull/122.patch https://github.com/geoffdavis/esphome-mitsubishiheatpump/pull/122.diff

-- Reply to this email directly or view it on GitHub: https://github.com/geoffdavis/esphome-mitsubishiheatpump/pull/122 You are receiving this because you were mentioned.

Message ID: @.***>

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

markalston commented 6 months ago

Looks like I accidentally made my initial pull request against my master branch which I was still working on. Thus all the other changes you notices and caused problems. This is the correct fix.

geoffdavis commented 2 days ago

Resolved elsewhere in the develop branch, closing.