search

geoffdavis / esphome-mitsubishiheatpump

ESPHome Climate Component for Mitsubishi Heatpumps using direct serial connection
BSD 2-Clause "Simplified" License
498 stars 143 forks source link

Fix version pinning of SwiCago/HeatPump library #125

Closed stewartadam closed 2 days ago

stewartadam commented 7 months ago

Pins the library to SwiCago/HeatPump@cea90c5ed48d24a904835f8918bd88cbc84cb1be which is the last stable commit I was able to test with my MSZ-GL06NA. More recent commits cause serial communication to silently fail (fixes #71 for me).

This PR also moves the version pin into the repository parameter as the version property of cg.add_library() appears to be entirely ignored in favor of version provided by the metadata in the repository instead. Since SwiCago doesn't version its library, we should version by Git commit instead.

Prior to this change, the latest commit was always being used which is why the issue in #71 suddenly appeared for me after rebuilding my m5stamp pico firmwares with no other changes.

stewartadam commented 7 months ago

Reported https://github.com/SwiCago/HeatPump/issues/207 upstream.

stewartadam commented 6 months ago

SwiCago/HeatPump#207 has been fixed upstream, so I've updated the version pin to point to the merge commit for its PR#209 that includes a fix when the library is initialized without specifying custom gpio pins.

geoffdavis commented 2 days ago

@stewartadam I rebased this onto the develop branch, which had a minor merge conflict.