search

geofot96 / StudyBuddy

2 stars 5 forks source link

Merge the calendar UI #127

Closed geofot96 closed 5 years ago

YBouquet commented 5 years ago

Maybe in order to decrease the amount of lines of code written in your ColorChaningTest, you can create a method for code that is periodically use. For example:

 private Matcher<View> getChild(int position){
          return  allOf(childAtPosition(
                        allOf(withId(R.id.calendarGrid),
                                childAtPosition(
                                        withId(R.id.generalThing),
                                        1)),
                        position),
              isDisplayed());
}

or something like that

geofot96 commented 5 years ago

It is only there for button existence tests because travis takes some time to locate them, I removed them from everywhere else

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 98ee9cab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 87.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.2% (3.2% change).

View more on Code Climate.