Closed YBouquet closed 5 years ago
geofot96
commented
5 years ago Great work! Mostly in GroupsActivityLeadsToCreateGroup.java but also in CourseSelectActivityTest.java there are many tests that are commented out. Why is that? Are they redundant? If not I think it would be a good idea to uncomment them (that's what I did in my branch). If they are then maybe we could put the searchBarExists test in GroupsActivity and delete the other file.
YBouquet
commented
5 years ago @geofot96 all tests that are commented out and not redundant were already commented out. I didn't comment them out. The others that are commented but redundant were commented out.
codeclimate[bot]
commented
5 years ago Code Climate has analyzed commit 502ee300 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 68.8% (50% is the threshold).
This pull request will bring the total coverage in the repository to 79.8% (6.5% change).
View more on Code Climate.
The ConnectedAvailability class would allow user to modify his availabilities that will be register in firebase for a selected group while the ConnectedCalendar will retrieve every user's availabities associated to the Calendar's group in real time. Also, a default list of availabilities will be register in firebase for the user during the creation of a group.
Duplicated tests are removed and so GroupsActivityLeadsToCreateGroup.java is deleted as every other tests were commented. I deleted group_userTests which was an empty class.
All uses of DummyCourses.java are deleted so that this class is now deleted it as well.
GoogleSignInActivity is corrected, now only one startActivity() is called during a single process, so that conflicts are now avoided. Furthermore, in this activity, fetchUserAndStart() method will exclusively use the firebaseUser account and won't fetch the googleSignInAccount() in order to avoid duplicate users in the database.