geohci / edit-types

Edit diffs and type detection for Wikipedia
MIT License
12 stars 3 forks source link

Links within links result in incorrect parsing #21

Closed geohci closed 2 years ago

geohci commented 2 years ago

Links within a link (often with images) messes up mwparserfromhell -- e.g., [[File:image.jpg|thumb|image caption with a [[link]] in it]] is parsed as [[File:image.jpg|thumb|image caption with a (Text), [[link]] (Wikilink), and ]] in it (Text). This needs to be handled upstream -- see https://github.com/earwig/mwparserfromhell/issues/270

geohci commented 2 years ago

This has been resolved in mwparserfromhell version 0.6.4 so we should probably enforce that when we put in a requirements.txt or equivalent