update modual to D&D 4x and provide small fix for 3.3.1

[Zarhog]

Modual has some seeminly random behaviour in 3.3.1 where it will not always show the subclass option.

a small update for 3.3.1 to fix this bug is required "if no subclasses are deteected, the subclass option should be skiped and hidden" "if subclass is detected then it should be show"

in D&D V4.x they have added a field to determin at which level a subclass should be appiled for this the additional check of "if Level of Class < Subclass requirment, Do not show subclass, and skip" "if Level of class => subclass requiremnt then show subclass"

[geoidesic]

I'm not able to replicate this. SRD cleric shows subclass, in both versions.

What exactly are you trying to achieve? I'm not understanding what the problem is. Maybe provide the data that is causing the issue and give me a bit more to go on.

Actor studio doesn't decide whether to hide or show subclasses at different levels. That's not a feature it has currently, so if you wanted that it wouldn't be a bug-fix, it would be a new feature.

What it does currently is just this:

• When you select a class, it looks at the compendiums linked for SubClasses and it sees if any of those items are listed by the selected class as being the registered subclass for that class.
• It does this by this conditional: subClass.system.classIdentifier == characterClass.system.identifier

If there's a match, it will show it, regardless of level. It doesn't care about the level for this. I'm not even aware of how it could potentially know this – I'm not aware of how one might set up a class in such a way so that there's a subclass that is only selectable at a certain level. You might need to go into that if that's a thing.

[geoidesic]

The title is also a bit confusing. Please try to stick to one issue per issue – i.e. avoid the word "and". You mention upgrade to 4.0.0 in the title but then you don't explain why that is necessary or what exactly needs to be upgraded that isn't working in that version. Version 1.5.2 already works on dnd5e v4.0.1, so I'm not aware of any necessary upgrade. If there is something not working in that version, please raise a separate issue for it.

Tx

[geoidesic]

I'm also not aware of any difference in behaviour between v4.0.0 and v3.3.1 wrt dnd5e and Actor Studio. It works in both, so I don't know what this extra field is to which you are referring that the dnd team told you about. I don't know what that is.

I think, if I read between the lines, that what you're actually asking for is a new feature – which is that the subclass select should be hidden if it has no options.

Does that sound correct?

[geoidesic]

But then I just tested that and it already does that. So, nope, I don't know what to do here.

[Zarhog]

Apoligies. please ignore this.

it was a Captalisation error with "Cleric" and "cleric"