search

geomesa / geomesa-geoserver

A GeoMesa community project for GeoServer-GeoMesa modules.
GNU General Public License v2.0
20 stars 17 forks source link

Add elasticsearch high-level client to post monitoring information #38

Closed nah6qg closed 4 years ago

nah6qg commented 4 years ago

Updated plugin to use elasticsearch high-level client. Feedback is appreciated!

jnh5y commented 4 years ago

As one more wrinkle, this was in the geomesa-gs-security module for historical reasons. We can probably change the name to be something more descriptive like gs-monitor-elasticsearch (or geomesa-gs-monitor-elasticsearch).

@elahrvivaz preference on the name?

elahrvivaz commented 4 years ago

no preference, i'd just keep it starting with geomesa-gs- for consistency. if this is in it's own module/jar, then i'm less concerned about it blowing up geoserver when it's included without config.

nah6qg commented 4 years ago

This version is in it's own module called geomesa-gs-monitor-elasticsearch and allows for multiple url's and catches some errors/issues a little bit better

elahrvivaz commented 4 years ago

looks pretty good now, just some minor comments on errors around parsing the env vars.

are we going to add documentation for this to the main repo?

nah6qg commented 4 years ago

@jnh5y Did a decision ever get made how we are going to document this?

jnh5y commented 4 years ago

@jnh5y Did a decision ever get made how we are going to document this?

Not quite. I think we can ship this as-is and figure that out in a bit.