geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
410 stars 487 forks source link

Elastic search documentation issues with record.json #7550

Open ianwallen opened 8 months ago

ianwallen commented 8 months ago

Describe the bug For elastic search documentation it has the following https://github.com/geonetwork/core-geonetwork/blob/main/es/README.md#configuration

It references -d @../web/src/main/webapp/WEB-INF/data/config/index/records.json

But that folder does not have a record.json file

https://github.com/geonetwork/core-geonetwork/tree/main/web/src/main/webapp/WEB-INF/data/config/index

Looks like in commit 40cce30d0513ee66c07fe8a907de6909c6ecf9be The file was changed location to the following location. https://github.com/geonetwork/core-geonetwork/blob/main/web/src/main/webResources/WEB-INF/data/config/index/records.json

Is that the correct location? If so then the documentation should be updated.

fxprunayre commented 8 months ago

Is that the correct location? If so then the documentation should be updated.

as the file is created at build time with variable substitutions, maybe it is better to point to the packaged webapp file location (and remove any link to github source)? I'm also not sure if we should highlight how to manually create the index as user can do it from the admin UI, so we can remove that section also maybe? The only case where a user might want to do it manually is when you enable security in Elasticsearch and the GeoNetwork elastic user has no privileges to create an index. Not use how often that happens.