Catch and raise HTTP 403 Forbidden errors

geopython / OWSLib

OWSLib is a Python package for client programming with Open Geospatial Consortium (OGC) web service (hence OWS) interface standards, and their related content models.

https://owslib.readthedocs.io

BSD 3-Clause "New" or "Revised" License

393 stars 278 forks source link

Catch and raise HTTP 403 Forbidden errors #958

Closed geographika closed 23 hours ago

geographika commented 3 weeks ago

It would have been easier to see the reason for recent failing CI tests (see #956) if an error had been raised when HTTP code 403 was returned.

As HTTP error code is a client error code, I added to the list with 400 and 401 (rather than the server error codes 5xx list).

See also #936.

Note, this could break existing workflows by raising a ServiceException - so comments/thoughts welcome.

coveralls commented 3 weeks ago

coverage: 60.107% (-0.1%) from 60.254% when pulling b3dfe7fc255fd6219ea673d832e92a53df10c100 on geographika:403 into 40cfa45c41d1695bdf1f3259c5f8c85ed4067fca on geopython:master.

landryb commented 2 weeks ago

matches what i had tried in #936, much welcomed !