Closed pmauduit closed 3 months ago
Thanks @groldan for the review
squash-merge them into your original commit.
:+1:
thymeleaf templates for e.g. login are not resolved anymore after this merge, I cannot explain why for now, but hitting /login will return the "login" string as response body.
Considering the following configuration scenario:
createUsersInGeorchestraLdap
set to trueThen the resolved
GeorchestraUser
should be anExtendedGeorchestraUser
, in order to have a behaviour coherent with the geOrchestra LDAP authentication (via the classic login form provided by the gateway).Without doing so, users externally authenticated will resolve as a classic GeorchestraUser, leading to missing http headers and breaking some geOrchestra applications (e.g. datafeeder, which requires the
sec-orgname
provided only when resolving to anExtendedGeorchestraUser
).This also refactors the
LdapConfigProperties
toGeorchestraGatewaySecurityConfigProperties
, as the object is not only about LDAP, but also nests some other configureable features (OIDC, ...).Documentation has been updated to describe / explain the behaviour.
Tests:
IMPORT
role, being externally authenticated, I was able to import a dataset following the datafeeder wizard.