search

georchestra / georchestra-gateway

GNU General Public License v3.0
0 stars 5 forks source link

preauth - being able to receive base64-encoded headers #90

Closed pmauduit closed 8 months ago

pmauduit commented 8 months ago

As Netty will always consider received headers as US-ASCII encoded strings, this can lead to issues when the values contain accented characters.

With this new feature, it is possible to consider the headers values as base64-encoded, which will be decoded before use.

Tests: IT added.

pmauduit commented 8 months ago

Updated / force-pushed to take into account @groldan 's feedback: instead of setting a new configuration property, we can assume that if the the header's value is prefixed with {base64} then the rest will be base64-encoded ; this also allows to reuse the existing code from georchestra-commons, which was already taking care of base64-decoding.

Also updated the doc / apache2 mod_mellon configuration example.

pmauduit commented 8 months ago

@groldan ready for review