george-yeo / pe

0 stars 0 forks source link

Name field is too restrictive #3

Open george-yeo opened 2 weeks ago

george-yeo commented 2 weeks ago

Steps to Reproduce

  1. Add a person with characters like commas, for example add name/yeo bing teck, george email/test@example.com telegram/@telegram github/george-yeo

Expected Outcome

Such characters should be allowed in a name, as it is part of acceptable legal names of certain people.

Actual Outcome

Error message is produced "Names should only contain alphanumeric characters and spaces, and it should not be blank"

image.png

soc-se-bot commented 1 week ago

Team's Response

Currently this is not implemented since we want to prevent overzealous input validation of names. With such names where there are commas or other special character involved, the workaround is to remove those characters and then key in the name normally. This works as our program does not expect the name of students to match their legal names. However, in the future we plan to provide more leeway and flexibility for the TAs to key in the names.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is a case of overzealous input validation, where characters allowed in legal names are prohibited by the developers.

While it is true users can remove the special characters in input, it would still restrict users from inputting the special characters when they did not know about it, causing an inconvenience when names should ultimately be given flexibility for the user to decide.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]