Rubix982/make deps - Githubissues

georgeamccarthy / protein_search

The neural search engine for proteins.

GNU Affero General Public License v3.0

15 stars 6 forks source link

Rubix982/make deps #56

Closed Rubix982 closed 2 years ago

Rubix982 commented 3 years ago

PR type

🏆 Enhancements - this PR should close #52

Why?

make deps previously assumed all dependencies to exist at the root. Because of Docker-related changes, changes have been made for users who do not wish to use Docker
The current changes work in a way where you need to open two terminals for the frontend and the backend services to start, and can be started with make front, and make back.

Feedback required over

A quick pair of :eyes: on the code
Discussion on the technical approach

Mentions

@fissoreg I think my git tree is broken. Also, what do you think about the approach and the changes? I introduced an ENV VAR called DOCKER in the frontend container to make the URL act differently based on what approach is used.

Legal

[X] I have read and agreed to the terms of contributing.

Rubix982 commented 3 years ago

Resolved merge conflicts.

fissoreg commented 3 years ago

The ENV var seems fine to me @Rubix982 :+1:

Rubix982 commented 3 years ago

@fissoreg should this be merged now?

fissoreg commented 3 years ago

Sure @Rubix982 sorry for the delay, I'll get to this today.

Rubix982 commented 2 years ago

Closing.