georgerobotics / cyw43-driver

Other
83 stars 45 forks source link

minor: configurable default interface params before dhcp is up #41

Closed bruelltuete closed 1 year ago

bruelltuete commented 2 years ago

In cyw43_cb_tcpip_init(), there are some parameters configured for the interface before dhcp has had a chance to run. Would be nice if those were configurable (via macros?). Esp the google dns server probably warrants a more prominent entry in a config file, e.g. cyw43_configport.h. https://github.com/georgerobotics/cyw43-driver/blob/2ab6ca93f9cd044bc6f35c1403b1284e4161294a/src/cyw43_lwip.c#L143

peterharperuk commented 2 years ago

Yes, you're right.

dpgeorge commented 1 year ago

Fixed by 5f396836c8e9a748849b121377bf442388571716