georgetown-cset / funder-finder

Retrieve GitHub repo funding information
Apache License 2.0
7 stars 2 forks source link

Add tidelift retriever basic test and functionality #32

Closed jspeed-meyers closed 1 year ago

jspeed-meyers commented 1 year ago

Fix #14

Signed-off-by: John Speed Meyers jsmeyers@chainguard.dev

github-actions[bot] commented 1 year ago

No need for rebasing :+1: behind_count is 0 ahead_count is 6

github-actions[bot] commented 1 year ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
380 262 69% 0% 🟢

New Files

File Coverage Status
funderfinder/sources/tidelift.py 73% 🟢
tests/sources/test_tidelift.py 100% 🟢
TOTAL 87% 🟢

Modified Files

No covered modified files...

updated for commit: a84b43c by action🐍

jspeed-meyers commented 1 year ago

@jmelot, the tests seem to pass, but there is an error with the linting, though it seems to be related to a CI issue, not the code itself. Can you make heads or tails of it?

Also, with this PR I've tried to bring the Tidelift retriever in line with the new schema and how the codebase implements it. Feedback is welcome. It is a Monday morning after all :)

jspeed-meyers commented 1 year ago

@jmelot, you are too good! Nice work identifying and fixing the issue.

jmelot commented 1 year ago

Sorry about that, that check started failing in some of our other repos earlier this week. Glad all is well now. I got distracted last night but will finish up the review and reply to your other comments later this weekend, excited to have this new "finder" added in!

jspeed-meyers commented 1 year ago

@jmelot - Agreed. I'll merge this plus open a new issue for exactly what you describe.