georgewfraser / java-language-server

Java language server using the Java compiler API
MIT License
659 stars 130 forks source link

Couldn't start Java Language Server #140

Open OOP-778 opened 4 years ago

OOP-778 commented 4 years ago

Hello after tree-sitter fix, there's new issue. mainThreadExtensionService.ts:66 Error: spawn UNKNOWN at ChildProcess.spawn (internal/child_process.js:394:11) at Object.spawn (child_process.js:553:9) at c:\Users\Brian.vscode-insiders\extensions\georgewfraser.vscode-javac-0.2.32\node_modules\vscode-languageclient\lib\main.js:357:40

OOP-778 commented 4 years ago

@georgewfraser

georgewfraser commented 4 years ago

Hmm, I think there's something VSCode on windows doesn't like about the async init function. It might be this await:

https://github.com/georgewfraser/java-language-server/blob/b75671304e9611c2d64511310d1e6caef0834dfb/lib/extension.ts#L128

It's a bit tricky for me to troubleshoot on Windows because I don't have a windows machine handy. Could you clone the repo and try commenting out:

await loadStyles();
applySemanticColors();

and the doing ./scripts/build.sh and see if that fixes it?

OOP-778 commented 4 years ago

Will do, maybe you have got a discord? Would be easier to communicate?

On 2020-03-14, Sat at 19:56, George Fraser notifications@github.com wrote:

Hmm, I think there's something VSCode on windows doesn't like about the async init function. It might be this await:

https://github.com/georgewfraser/java-language-server/blob/b75671304e9611c2d64511310d1e6caef0834dfb/lib/extension.ts#L128

It's a bit tricky for me to troubleshoot on Windows because I don't have a windows machine handy. Could you clone the repo and try commenting out:

await loadStyles(); applySemanticColors();

and the doing ./scripts/build.sh and see if that fixes it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/georgewfraser/java-language-server/issues/140#issuecomment-599110180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6QE2JYHP22YWWS7HM2OMLRHPAMBANCNFSM4LEIZ7JA .

georgewfraser commented 4 years ago

I think github issues is the best way.

OOP-778 commented 4 years ago

Alright, I’ll do that whenever I’m on my computer.

On 2020-03-14, Sat at 20:01, George Fraser notifications@github.com wrote:

I think github issues is the best way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/georgewfraser/java-language-server/issues/140#issuecomment-599111278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6QE2IRO6NQTTZ4Q73KDDDRHPBBBANCNFSM4LEIZ7JA .

OOP-778 commented 4 years ago

Getting same error

kigero commented 4 years ago

I'm getting the same error with v0.2.33, and took a quick look at what's going on. It looks like the language server isn't starting up at all from VSCode on windows. The command that it's trying to run in order to launch the language server is C:\Users\username\.vscode\extensions\georgewfraser.vscode-javac-0.2.33\dist\lang_server_windows.sh, and looking at this file it is indeed a shell script. Is this supposed to be working on windows? I would have expected a bat file, but maybe there's some magic to run this on windows that I'm not aware of.

I hacked up a quick bat file based on the script and was able to get the language server to run successfully from VSCode, but then I started getting errors like this, so I suspect that there's more going on than just getting the server to start:

mainThreadExtensionService.ts:66 Error: Message header must separate key and value using :
    at c:\Users\username\.vscode\extensions\georgewfraser.vscode-javac-0.2.33\node_modules\vscode-jsonrpc\lib\messageReader.js:57:23
    at Array.forEach (<anonymous>)
    at MessageBuffer.tryReadHeaders (c:\Users\username\.vscode\extensions\georgewfraser.vscode-javac-0.2.33\node_modules\vscode-jsonrpc\lib\messageReader.js:54:17)
    at StreamMessageReader.onData (c:\Users\username\.vscode\extensions\georgewfraser.vscode-javac-0.2.33\node_modules\vscode-jsonrpc\lib\messageReader.js:157:43)
    at Socket.<anonymous> (c:\Users\mcminn\.username\extensions\georgewfraser.vscode-javac-0.2.33\node_modules\vscode-jsonrpc\lib\messageReader.js:148:18)
    at Socket.emit (events.js:203:13)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:276:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)
georgewfraser commented 4 years ago

We should really get rid of the tree-sitter parts, in favor of using the native semantic coloring features that have been added to vscode.

8746070404 commented 2 months ago

couldnt start java language server