search

georgringer / news

TYPO3 Extension news
GNU General Public License v2.0
264 stars 358 forks source link

NewsCategory Aspect not working as expected #2165

Closed infabo closed 1 year ago

infabo commented 1 year ago

https://github.com/georgringer/news/blob/73bca170bd954b0904565c6f827167b4abe17f8e/Classes/Routing/AbstractNewsAliasMapper.php#L45

Due to this compatibility check, resolve return a string with character 0. I don't see a reason for doing this in v11, as v11 already declares ?string and therefore null as a perfectly valid value (see https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php#L166).

The string 0 on the other hand breaks the news category filter functionality and instead the news-list outputs Dieser Artikel ist nicht mehr verfügbar..

infabo commented 1 year ago

I no longer use these unnecessary aspects anyway. Keep your bug.

Thank you for caring!