Fix #10615 removed eval from marker utils - Githubissues

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!

https://mapstore.geosolutionsgroup.com/

Other

515 stars 402 forks source link

Fix #10615 removed eval from marker utils #10616

Closed MV88 closed 1 month ago

MV88 commented 1 month ago

Description

refactor for eval function

fontJSON[key] holds the hexadecimal code for the glyph (without the \u prefix).
parseInt(fontJSON[key], 16) converts the hexadecimal string to a decimal number.
String.fromCharCode() generates the corresponding character from the Unicode code point.

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Issue

What is the current behavior?

Fix #10615

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

[ ] Yes, and I documented them in migration notes
[x] No

Other useful information

allyoucanmap commented 1 month ago

@ElenaGallo please test this fix on dev and let us know if we can backport on 2024.02.xx, thanks