geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
515 stars 402 forks source link

Returning wrong pixel xy value on mousemove for leaflet engine #10677

Closed shivadas1980 closed 1 week ago

shivadas1980 commented 1 week ago

Description

On mouse move over map using leaflet engine, it returns wrong pixel xy value. It always return x value for x and y.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

Issue

What is the current behavior?

On mouse move on map using leaflet engine, return x pixel value for both x and y pixel value.

What is the new behavior?

After this fix, on mouse move over map return correct xy pixel value for leaflet engine

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

Other useful information

ash03e608 commented 1 week ago

Hello @tdipisa , @allyoucanmap , This MR has been submitted from a team at Halliburton who is currently using Mapstore via the JS API. We are currently evaluating the stability of the Mapstore JS API and hence we are interested to know the history of this bug and if this was a recent regression. If not, is this a bug thats only exposed on the JS API and not via the React components. Since the workflow is fundamental and the error very obvious, i wanted to hear your thoughts on it.

tdipisa commented 1 week ago

@ash03e608 it is not a recent regression. That incorrect setup was introduced many years ago by this PR https://github.com/geosolutions-it/MapStore2/pull/1211, it seems. Probably because Leaflet map engine is less used and supported than OL/Cesium ones, this issue has never been reported before. Thank you very much for using MapStore.