[Actions - ds2ds] Support of multiple styles assignment in DSGeoServerAction

[eblondel]

Following a recent improvement of geoserver-manager to allow multiple styles assignment to a given GS layer (see https://github.com/geosolutions-it/geoserver-manager/issues/84), the DSGeoServerAction will be modified to support such assignment of multiple available styles to the GS layer to publish.

A pull request will be sent for master, then for 1.3.x if it's ok.

[ccancellieri]

Emmanuel, as far as I remember the GeoServerActionConfiguration is there to be extended by the action which may want to connect to the Geoserver for various purpose. Anyhow I also remember that GeoServerActionConfiguration may extends a class like GeoServerConfig (don't have the code under my hands). I think we have to evaluate to create a new Class extending this one which will then be used (extending it) to publish layers (you can call it GeoServerLayerConfiguration). On monday I'll check the code and contacto you to understand how to proceed. Cheers, Carlo

2013/7/6 Emmanuel Blondel notifications@github.com

Following a recent improvement of geoserver-manager to allow multiple styles assignment to a given GS layer (see geosolutions-it/geoserver-manager#84https://github.com/geosolutions-it/geoserver-manager/issues/84), the DSGeoServerAction will be modified to support such assignment of multiple available styles to the GS layer to publish.

A pull request will be sent for master, then for 1.3.x if it's ok.

— Reply to this email directly or view it on GitHubhttps://github.com/geosolutions-it/geobatch/issues/198 .

[eblondel]

Hi Carlo GeoServerActionConfig is the superclass of GeoServerActionConfiguration, and only addresses GS URL, user and pwd.

The DSGeoServerConfiguration yet extends GeoServerActionConfiguration, where actually the possibility to set-up multiple styles is already specified with setStyles(List styles) / getStyles() (but actually it was not supported by geoserver-manager until now).

Here, i just need to add very few lines of code in DSGeoServerAction to support assigning multiple styles to the layers...Smthg like:

if(conf.getStyles() != null){ for(String style : conf.getStyles()){ layerEncoder.addStyle(style); } }

I was looking to that now, but i have a pb with the geoserver-manager dep. 1.5-SNAPSHOT was well updated with the new code, but not 1.6-SNAPSHOT (used in master)...: addStyle / delStyle are not available, while i can see it was built yesterday: http://maven.geo-solutions.it/it/geosolutions/geoserver-manager/1.6-SNAPSHOT/ It would be great if you could have a look to that.

[ccancellieri]

GeoServerActionConfig is the superclass of GeoServerActionConfiguration, and only addresses GS URL, user and pwd.

The DSGeoServerConfiguration yet extends GeoServerActionConfiguration, where actually the possibility to set-up multiple styles is already specified with setStyles(List styles) / getStyles() (but actually it was not supported by geoserver-manager until now).

Here, i just need to add very few lines of code in DSGeoServerAction to support assigning multiple styles to the layers...Smthg like:

if(conf.getStyles() != null){ for(String style : conf.getStyles()){ layerEncoder.addStyle(style); } }

Ok, good.

I was looking to that now, but i have a pb with the geoserver-manager dep. 1.5-SNAPSHOT was well updated with the new code, but not 1.6-SNAPSHOT (used in master)...: addStyle / delStyle are not available, while i can see it was built yesterday: http://maven.geo-solutions.it/it/geosolutions/geoserver-manager/1.6-SNAPSHOT/ It would be great if you could have a look to that.

Looking at this problem the code is there: https://github.com/geosolutions-it/geoserver-manager/blob/master/src/main/java/it/geosolutions/geoserver/rest/encoder/GSLayerEncoder.java

The jar was deployed on 5th Jul by jenkins:

[INFO] Retrieving previous build number from geosolutions Uploading: ftp://maven.geo-solutions.it//it/geosolutions/geoserver-manager/1.6-SNAPSHOT/geoserver-manager-1.6-SNAPSHOT.jar

...

Could you try to add -U option to the mvn command to force SNAPSHOT update? If this will not solve I'll try to re-deploy it.

Cheers, Carlo

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more

information.

Dott. Carlo Cancellieri @cancellieric Software Engineer

GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 mobile: +39 3371094494 fax: +39 0584 1660272

http://www.geo-solutions.it http://twitter.com/geosolutions_it

---

[eblondel]

Ciao Carlo, I've updated snapshot and 1.6-SNAPSHOT was donwloaded: Downloaded http://maven.geo-solutions.it/it/geosolutions/geoserver-manager/1.6-SNAPSHOT/maven-metadata.xml but i still cannot access to addStyle/delStyle from gs-manager...

I've tested the 1.6-SNAPSHOT downloading the jar, and indeed everything is there. it seems i have an issue with maven update snapshots. ASAP i send you the 1st pull request