search

geotrellis / vectorpipe

Convert Vector data to VectorTiles with GeoTrellis.
https://geotrellis.github.io/vectorpipe/
Other
74 stars 20 forks source link

Upgrade to GT3.0 codebase #116

Closed moradology closed 5 years ago

moradology commented 5 years ago

Overview

This PR upgrades to GT 3.0. There are a few significant changes that deserve special attention in this regard:

  1. Spray -> Circe
  2. Geotrellis Geometries -> JTS Geometries
  3. AWS SDK V1 -> AWS SDK V2
  4. Overriding dependencies to avoid test failures due to jackson version 2.9 colliding with Spark's jackson version

Closes #115

jpolchlo commented 5 years ago

The true test of this would be if we can get OSMesa working with this new version without problem. I don't see any changes that are likely to block that, and we don't strictly need this confirmation, since the pressure to update versions isn't coming from that side. I would say we could/should defer that test, and call this PR provisionally OK.

jpolchlo commented 5 years ago

So, for this PR, we should prefer import geotrellis.vector._ to importing JTS, I think. We surely can import items from JTS, but in the interest of making sure GT's convenience extensions are available, the GT import is better.

CloudNiner commented 5 years ago

@jpolchlo

So, for this PR, we should prefer import geotrellis.vector._ to importing JTS

Done. See rebased commit https://github.com/geotrellis/vectorpipe/pull/116/commits/1d0f3bafe0f99612f504fbd1b2368e9fa5d013ae

jpolchlo commented 5 years ago

Pending Travis approval, this looks good to me.