search

geraldkoh4 / pe

0 stars 0 forks source link

DG diagram error #23

Open geraldkoh4 opened 1 year ago

geraldkoh4 commented 1 year ago

image.png

image.png

The activation bar for display data should have ended when control was returned.

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

DG formatting issues

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

I currently use adobe pdf reader and this is what I see.

Although cosmetic bugs are only supposed to be very low, this bug makes part of the diagram and the explanation of a whole component undecipherable. As such I give it a medium rating as it is inconvenient to many users, but they can still use the DG as a whole.

[original: nus-cs2113-AY2223S2/pe-interim#2734] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is a cosmetic bug

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The duplicate issue refers to formatting errors. This current issue refers to the activation bar errors. In my below argument, it is likely not a cosmetic error but most likely a conceptual one.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not just a simple cosmetic error, in the whole of the pdf there were many of these issues. A simple glance through the pdf should support my stand. The activation bars are an error and highly probable that it is not a cosmetic bug. When constructing the diagram (in intellj) a constantly updated diagram should be present to refer to, meaning it is highly unlikely a cosmetic bug, but rather a conceptual error.