geraldkoh4 / pe

0 stars 0 forks source link

No check for correct date in calorie tracking #8

Open geraldkoh4 opened 1 year ago

geraldkoh4 commented 1 year ago

image.png

When an obviously wrong date is inputted, there is no check for the correct dates. The date then overflows and the wrong date is displayed.

soc-se-bot commented 1 year ago

Team's Response

In the UG it is mentioned that it needs to be a present or a past date. However, this is an oversight.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: All numerical values that can be checked simply should be checked.

For example, in their calorie function, there was a check for 0 calories and negative calories, both of which were rejected.

In this case, the same can be done for the date, by checking 1-31 for days, 1-12 for months and checking for a valid year with acceptable but broad boundaries. (2000-2023 is fine, 2020-2023 is also fine).

This is a test case where the application works even when it should not. It is within the scope as they clearly said that it should be a present or a past date, which they should have checked.

If saying "User should input only correct userinput" is accepted as a correct reasoning, then virtually any bug is not in scope.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a test case where the application works even when it should not. It is within the scope as they clearly said that it should be a present or a past date, which they should have checked. The feature is not working as intended as it allows dates that are not present or past.