geraldmwangi / GuitarMidi-LV2

A concept for guitar to midi as an lv2 plugin
Other
51 stars 0 forks source link

GuitarMidi-LV2 wont route the sound and the MIDI path in Ardour5 #3

Open BeFrankly opened 2 years ago

BeFrankly commented 2 years ago

Hello, the initial configuration of an audio track in Ardour5 is, that it's in strict I/O mode so that a plugin only could have one output. If you add GuitarMidi-LV2 in this mode to a track it seem to be randomly, which of the output ports get connected and no warning comes up. So it was hard to find out.

In non strict I/O mode, there could be more than one output channels and the connection seems to be ok. See the picture. But still one could not get sound out of this track, when the GuitarMidi Plugin is in the track. The only way to get sound is when you activate "Bypass" on the gui of GuitarMidi. See the other pic. So I think this is a Bug because in Carla the audio output seems to work well. Other Plug-ins work well in Ardour. ;-)

Regards and good luck Frank

grafik

grafik

geraldmwangi commented 2 years ago

Can you test in Carla too?

geraldmwangi commented 2 years ago

With jack set to 256 frames

BeFrankly commented 2 years ago

@geraldmwangi , I did some further test and here is what I found. I tested the routing in carla and observed with two meters if the sound goes through your plug-in. I observed, that the sound comes out of the plug-in but with a little downgrade in volume. And the sound that comes out, when I listened to it, is much different that that's getting in. To demonstrate, id did a recording of this with audacity. you can see, how I patched in in the picture. The portaudio in_36 and in_37 is audacity. I randomly played some awful notes on the guitar, not well tuned and overdriven input, and as you can here, at some notes the output gets overdriven and on others it is low. So how comes? The recording is in the zip file. But to come back to this issue here. In carla there was no problem in getting sound out of the output in anyway, as you can see above.

I am running jack with 512 buffer size on 48k sample rate and an Tchelicon Go Twin audio interface.

Regards Frank

grafik Guitar MIDI test.zip

geraldmwangi commented 2 years ago

Ahh. Thanks for sharing. The output audio isnt actually meant for using. I use it as an internal buffer for the filters. The plugin implements a filterbank, each filter corresponds to one position on the fretboard of the guitar. What you hear is the output of the last filter in my filter bank. The midi out has midi notes extracted from the guitar signal. Thanks for the audio, I'll use it for developing. I pushed your recording to the repo. Is that ok?

geraldmwangi commented 2 years ago

The plugin is meant to be a sound to midi-only plugin. No synth effect of sorts

BeFrankly commented 2 years ago

Dear @geraldmwangi , yes it's ok to push the recording to the repo but only if tagged "badest, not artlike recording, unwell tuned" or something, you know what I mean. It's not the normal way I'm playing e-guitar. :-) But please, keep one thing in mind: for testing you should have your own recordings, I guess you have, and there have to be recordings of a good tuned and clean e-guitar and also acoustic guitar, and also recordings of a bad tuned, overdriven sound.

And, of course, test data, especially audio recordings, video and so on, that perhaps nee lot of space, should not be placed in the repository. They slow things down. An extra storage for that may be a good idea (but with the disadvantage of not having version controled them). It's up to you.

Coming to the audio output of your Plug-In: I guess that 90% of the users expect, that the unfiltered audio stream comes out of it. Think about that. Why not adding a second output, that's only for developing purposes and is not compiled into the official version?

Maybe in two weeks I'll do another post telling about my findings in the MIDI output. I'm on holiday a few days now.

Regards and good luck with further development.

Frank

geraldmwangi commented 2 years ago

@BeFrankly thanks, I'll consider removing the output or making it a copy of the input

geraldmwangi commented 1 month ago

@BeFrankly Can you test the latest release?