germainelee02 / pe

0 stars 0 forks source link

Modification of .json file leads to wiped database #1

Open germainelee02 opened 1 year ago

germainelee02 commented 1 year ago

If I modify the .json file to have the same name, upon relaunching of the app. It will wipe out the entire data. Screenshot 2023-04-14 at 2.20.21 PM.png

Result: Screenshot 2023-04-14 at 2.20.10 PM.png

This will be a big hassle to the users. In the documentation, there should be a section where you say that modification of the .json file should be careful not to have duplicate names

soc-se-bot commented 1 year ago

Team's Response

This DocumentationBug is accepted, but at a Low severity, as only advanced users are expected to update data directly by editing the data file. Additionally, advanced users would likely know that SOCket considers persons with duplicate names to be invalid, and would be unlikely to run into this behavior. However, we do acknowledge that it would be better to state what SOCket considers to be duplicate contacts in the documentation.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: > Additionally, advanced users would likely know that SOCket considers persons with duplicate names to be invalid, and would be unlikely to run into this behavior. However, we do acknowledge that it would be better to state what SOCket considers to be duplicate contacts in the documentation.

If you did not say what is considered a duplicate contact, how would you expect advanced users to know? Even if they are advanced users who know how to code, they are still using your product for the first few times. So your assumption is invalid

Actually, this should be a severity.High. And considering the fact that the entire database is wiped out. It is very severe.