germainelee02 / pe

0 stars 0 forks source link

Error message should be clearer #14

Open germainelee02 opened 1 year ago

germainelee02 commented 1 year ago

When I add an index out of bounds, the error message tells me I should add a flag first.

I believe that index out of bounds should be called first before the compulsory command flag

Screenshot 2023-04-14 at 3.00.16 PM.png

nus-pe-bot commented 1 year ago

Team's Response

This bug report is rejected, as the error message is accurate, as the user has not provided a field to editpj. If the user does input a valid format for the editpj command with an invalid index, the software would throw an appropriate error message.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I am saying that the error message for incorrect format should take precedence over the error message for having a field.

In the real world, users will choose which item to edit by choosing the index, then changing the flag.

Hence, the error message should reflect what happens in the real world.

Above, when I typed in an incorrect index, I expect an error message to say I was out of bounds, not that I am missing a flag. The error message of incorrect index should come before the flag error message.


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]