search

gerwaric / acquisition

Stash and forum shop management for Path of Exile
GNU General Public License v3.0
17 stars 3 forks source link

Filled coffin search #24

Closed AhmedBenAbdessalam closed 5 months ago

AhmedBenAbdessalam commented 6 months ago

the new league added new itemized corpses called Filled Coffin which have carious craft. It would be could if we can filter by mods for them like we can do with other items.

gerwaric commented 6 months ago

Thanks for the suggestion. I spent a few minutes investigating this issue, because the mods filter is a part of acquisition's code I have never worked with.

What I found is that acquisition gets its list of searchable modifiers from a file hosted by https://github.com/brather1ng/RePoE/. However, that repository has not been updated for about two years. I believe this means not only are Necropolis-specific mods excluded from acquisition searches, but any mods introduced since the last update to RePoE will also be effectively invisible to acquisition searches. Those modifiers are still displayed on the item when you click on it, but that is because item display is handled by different code.

If I (or someone else) can generate updated RePoE files, it might be possible to make coffin modifiers searchable.

gerwaric commented 5 months ago

Update: RePoE depends on PyPoE, and both appear to be abandoned per this thread: https://www.reddit.com/r/pathofexiledev/comments/141px6i/repoe/

However, that thread points to another repo which may replicate RePoE's functionality: https://github.com/lvlvllvlvllvlvl/RePoE

I don't yet know if the updates will break acquisition or not.

EDIT: The good news its that the version of RePoE maintained by lvlvllvlvllvlvl is compatible with acquisition. The bad news is that it doesn't appear to contain coffin modifiers, even though it was updated after the launch of Necropolis.

TLDR; I still don't know how much work it will take to get mods from recent leagues into acquisition.

gerwaric commented 5 months ago

I've been chatting with the PoE Wiki developers on discord, and this is not going to be easy to solve. They have added the necropolis modifiers to the output of PyPoE and RePoe, but there is some complexity that prevents those modifiers from "looking like" the other searchable modifiers that acquisition pulls from the stat translations json file.

I'm thinking about different ways to solve this, both for necropolis and also for future leagues, but the ideas I've brainstormed all mean big changes internally, so I don't think there will be a fix soon. Apologies.

gerwaric commented 5 months ago

@AhmedBenAbdessalam can you give this release a try to see if you can search for filled coffins?

https://github.com/gerwaric/acquisition/releases/tag/v0.10.3-alpha.5

AhmedBenAbdessalam commented 5 months ago

It's working great. Sorry for the late reply, I'm not sure why I didnt get notified when you mentioned me for some reason.

gerwaric commented 5 months ago

No worries. I'm glad it's working, so I'll close this issue for now.